Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding localization mvp #364

Open
wants to merge 24 commits into
base: development
Choose a base branch
from
Open

Conversation

User623-crypto
Copy link

No description provided.

@@ -0,0 +1,37 @@
// DO NOT EDIT. This is code generated via package:intl/generate_localized.dart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can delete deutsch for now.

Copy link
Member

@Xazin Xazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Analyzer and tests seem to fail

Xazin
Xazin previously approved these changes Mar 5, 2023
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Merging #364 (9025df4) into development (db8283d) will decrease coverage by 1.82%.
The diff coverage is 0.90%.

@@               Coverage Diff               @@
##           development     #364      +/-   ##
===============================================
- Coverage        65.65%   63.83%   -1.82%     
===============================================
  Files              161      165       +4     
  Lines             4067     4173     +106     
===============================================
- Hits              2670     2664       -6     
- Misses            1397     1509     +112     
Impacted Files Coverage Δ
lib/generated/intl/messages_all.dart 0.00% <0.00%> (ø)
lib/generated/intl/messages_en.dart 0.00% <0.00%> (ø)
lib/generated/intl/messages_nl.dart 0.00% <0.00%> (ø)
.../infrastructure/auth/firebase_auth_repository.dart 40.20% <0.00%> (-4.96%) ⬇️
lib/presentation/core/app_widget.dart 0.00% <0.00%> (ø)
lib/presentation/core/error_widget.dart 0.00% <0.00%> (ø)
lib/presentation/demo/demo_screen.dart 0.00% <0.00%> (ø)
lib/generated/l10n.dart 2.22% <2.22%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wizlif
Copy link
Collaborator

wizlif commented Mar 18, 2023

@User623-crypto Please fix conflicts and merge

@User623-crypto
Copy link
Author

@User623-crypto Please fix conflicts and merge

@wizlif done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants